Update authors.py #210
Merged
Update authors.py #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From version 1.10.1 of Scipy: https://github.com/scipy/scipy/blob/c1ed5ec/tools/authors.py I started up by trying to remove obsolete Python 2 stuff: from scipy._lib.six import u, PY3 Ended up sync'ing this vendored file with upstream.
|
tbh I don't even know how this file was used originally. I never touched it since starting to maintain this repo. @holgern do you know anything? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From version 1.10.1 of Scipy:
https://github.com/scipy/scipy/blob/c1ed5ec/tools/authors.py
I started up by trying to remove obsolete Python 2 stuff:
Ended up sync'ing this vendored file with upstream.
Do you really need it, by the way? The previous version wouldn't have worked with recent versions of SciPy any way, as they lack
scipy._lib.six.