Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS ARM64 wheels #244

Closed
wants to merge 1 commit into from
Closed

Conversation

cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Oct 9, 2023

I noticed that macOS ARM64 wheels are missing, so hopefully this PR will add them. Is there a way to test if this works on cibuildwheel?

@skjerns
Copy link
Collaborator

skjerns commented Oct 9, 2023

yes, but only on branches from the same repo. I added them here #245 , it seems to work

@cbrnr
Copy link
Contributor Author

cbrnr commented Oct 9, 2023

Are the wheels available for download so that I can test installing them locally? I don't see the output...

@skjerns
Copy link
Collaborator

skjerns commented Oct 9, 2023

Not yet, need to make a new release for that, will do later

@cbrnr
Copy link
Contributor Author

cbrnr commented Oct 9, 2023

But I meant how do you know that the wheels are building OK when they are not being built? Or are they, and there are just no artifacts to download?

@skjerns
Copy link
Collaborator

skjerns commented Oct 9, 2023

they were build, but not uploaded due to no new release, the current build should be done any minute and then upload them

@cbrnr
Copy link
Contributor Author

cbrnr commented Oct 9, 2023

Where do you see that they were successfully built?

@skjerns
Copy link
Collaborator

skjerns commented Oct 9, 2023

Where do you see that they were successfully built?

https://github.com/holgern/pyedflib/actions/runs/6459073038/job/17534120890

@cbrnr
Copy link
Contributor Author

cbrnr commented Oct 9, 2023

Thanks! But that happens only when you create a new tag, right? Would it not be useful to build all wheels for every PR? I mean, if you want to avoid a situation where wheels fail, then you would have to create another tag just to fix the wheels.

@skjerns
Copy link
Collaborator

skjerns commented Oct 9, 2023

The wheel building can also be started by workflow dispatch, but then the wheels wont upload to pypi, that only works if the version is incremented :)

I tested the wheels build on a branch and once that was confirmed, I created the tag

@cbrnr
Copy link
Contributor Author

cbrnr commented Oct 9, 2023

Ah, got it!

@skjerns skjerns closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants