-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added high-level functions #65
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 10.59% 12.81% +2.21%
==========================================
Files 6 7 +1
Lines 3274 3520 +246
Branches 82 136 +54
==========================================
+ Hits 347 451 +104
- Misses 2886 3026 +140
- Partials 41 43 +2
Continue to review full report at Codecov.
|
(note: need to add digitial for non-same sampling frequency) |
@holgern do you think it's worth pursuing this? btw: some of the added dependencies can be dropped or made optional. |
@skjerns Thanks for your work. I would like to have the added dependencies dropped or made optional. They can be added to the test requirements but should not be required to install the package itself. |
alright.. I removed the deps, they should not really be needed anyway. I'll work on some of the functions and implement some tests, then we can merge (if you're okay with the code.) |
@holgern I added the docstrings and tests. Can you see if this can be merged? I'll write some more documentation then. btw, I would volunteer to take up part of maintenance of the repository, if you would think that would be an idea. |
Great work, it looks good now. This will simplify the usage of pyedflib. I think I have to create a new github organization first, before I can add maintainer. |
@holgern I think it should work without an organiztion, you just have to click on the settings above and under |
@skjerns You were right, I invited you as collaborator. |
I thought it might be useful to add some high-level functions for convenience.
I've created the following functions:
@holgern Let me know if you think this could be useful. Then I'll create the tests and integrate the imports into the package.