Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type of note field that is string doesn show #487

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

Mrxyy
Copy link
Contributor

@Mrxyy Mrxyy commented Dec 24, 2023

Summary

  • Short summary of the task, what have been done etc
  • Please include screenshots whenever possible (important).

Issue

#485

Lasting Changes (Technical)

Checklist

@nguyenalter
Copy link
Contributor

@Mrxyy Please help add some test cases when importing both note types. Thank you.

@Mrxyy
Copy link
Contributor Author

Mrxyy commented Jan 11, 2024

@Mrxyy Please help add some test cases when importing both note types. Thank you.
I have added test cases for them in the tests/model_exporter/**/input/default_tables.in.json file. And all of them have been approved locally by me.

@nguyenalter nguyenalter added the PR: Bug Fix 🐛 A type of pull request used for changelog categories label Jan 18, 2024
@nguyenalter nguyenalter merged commit 3ad97ee into holistics:master Jan 18, 2024
1 of 2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Apr 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 A type of pull request used for changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants