Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dbml alias & primary key & note content bug #504

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

Huy-DNA
Copy link
Contributor

@Huy-DNA Huy-DNA commented Feb 1, 2024

Summary

  • Fix error message when alias is a duplicate.
  • Allow alias to be the same as the same table's name
  • Interpret primary key
  • No longer normalize note content, left as-is.

Issue

(issue link here)

Lasting Changes (Technical)

  • Additional check in TableValidator.
  • Additional logic in TableInterpreter.
  • Remove normalizeNoteContent.
  • Testcases for these.

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

@Huy-DNA Huy-DNA changed the title Fix/dbml alias primary key bug Fix/dbml alias & primary key & note content bug Feb 1, 2024
Copy link
Contributor

@NQPhuc NQPhuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Huy-DNA Huy-DNA requested a review from NQPhuc February 1, 2024 05:51
@Huy-DNA Huy-DNA merged commit 2543adc into master Feb 1, 2024
3 checks passed
@Huy-DNA Huy-DNA deleted the fix/dbml-alias-primary-key-bug branch February 1, 2024 05:52
@NQPhuc NQPhuc added the PR: Bug Fix 🐛 A type of pull request used for changelog categories label Feb 1, 2024
@coderabbitai coderabbitai bot mentioned this pull request Apr 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 A type of pull request used for changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants