Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type errors and missing return #509

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: type errors and missing return #509

merged 1 commit into from
Feb 5, 2024

Conversation

Huy-DNA
Copy link
Contributor

@Huy-DNA Huy-DNA commented Feb 5, 2024

Summary

Fix the problems as pointed out in: https://holistics.slack.com/archives/C0278BDLPK8/p1706870126558909.
NO breaking change is introduced!

  • Add the missing return after creating the new Report, make that line meaningless
  • Add the check whether container.name is an instance of an IdentifierStream node, otherwise, there will be an uncaught error when it's actually a PrimaryExpresssionNode.
  • Add the any assertion.

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • (Added class EmailValidator to validate email address' validity)
  • (Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

@Huy-DNA Huy-DNA requested a review from nguyenalter February 5, 2024 06:02
Copy link
Contributor

@nguyenalter nguyenalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Huy-DNA Huy-DNA merged commit 6dc1d41 into master Feb 5, 2024
3 checks passed
@Huy-DNA Huy-DNA deleted the fix-trivial-bugs branch February 5, 2024 08:25
@Huy-DNA Huy-DNA added the PR: Bug Fix 🐛 A type of pull request used for changelog categories label Feb 5, 2024
@coderabbitai coderabbitai bot mentioned this pull request Apr 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 A type of pull request used for changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants