chore/upgrade vite plugin dts & fix tsconfig to properly include all sources #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huy-DNA
added
PR: Bug Fix 🐛
Huy-DNA
force-pushed
the
chore/upgrade-vite-plugin-dts-and-fix-tsconfig
branch
from
3e5edc1 to
8e82a8c
Compare
nguyenalter
reviewed
Sep 12, 2024
nguyenalter
approved these changes
Sep 13, 2024
nguyenalter
deleted the
chore/upgrade-vite-plugin-dts-and-fix-tsconfig
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
vite-plugin-dts, which resolves this security issue.tsconfigtoincludeallsrcnot just the entry file, resolving this issue.vite-dts(intendedvite-plugin-dts)Issue
(issue link here)
Lasting Changes (Technical)
(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)
class EmailValidatorto validate email address' validity)Tenant#is_trial?check)Checklist
Please check directly on the box once each of these are done