Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #3

Merged
merged 8 commits into from
Nov 3, 2017
Merged

Small fixes #3

merged 8 commits into from
Nov 3, 2017

Conversation

forabi
Copy link
Contributor

@forabi forabi commented Oct 6, 2017

  • Do not display error.code in query result for privacy reasons: This could reveal whether a user is registered by attempting to createUser with the same email.
  • Fix configuration of GraphQL extension for VS Code
  • Add debug npm script to use with VS Code (no longer needed, Support Docker Compose-based development workflow #4 adds --inspect for debugging)
  • Import from GraphQL submodules for consistency
  • Lowercase user email address
  • Fix comment in schema

@wholesomedev
Copy link
Contributor

🙈 🙉 🙊

Copy link
Contributor

@wholesomedev wholesomedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@forabi forabi merged commit f02f5fe into hollowverse-archive:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants