Move zome templates out of core repo and support third party templates #1565
Conversation
willemolding
changed the title
|
Not sure about the best way to go about testing. I don't want to slow down the current CI cycle but it would be nice to have the peace of mind that using |
There was a problem hiding this comment.
I like this step in general for sure!
One thing that we discussed when it was actually a 'git clone' in the past, was the fact that this means that hc generate can only be used while you have an internet connection, which is a touch sad. That said, it's worth testing for/checking for what the behaviour of this command would be if you did not have internet at the time, and hopefully making it a decent experience in that case too.
cli/src/config_files/build.rs
Outdated
| @@ -24,13 +24,13 @@ impl Build { | |||
| Ok(build) | |||
| } | |||
|
|
|||
| pub fn save_as<T: AsRef<Path>>(&self, path: T) -> DefaultResult<()> { | |||
| let file = File::create(path)?; | |||
| // pub fn save_as<T: AsRef<Path>>(&self, path: T) -> DefaultResult<()> { | |||
There was a problem hiding this comment.
Why doing just commented out code?
Co-Authored-By: Connor Turland <connor.turland@holo.host>
|
@willemolding oh i think this needs the merge conflicts solved, the diff looks pretty messy atm? |
PR summary
Maintaining the template zomes produced by
hc generatein the core repo was awkward. This PR:hc generate path/to/zome https://github.com/username/template-repo. As long as they follow our templating convention ({{ version }}, {{ author }} and {{ name }} for the moment) it will fill these fields.followups
If there is pull for it we could also add support for user defined template fields which are passed to
hc generateas an extra param.changelog
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)