Allow Rust to be provided for app development #52
Conversation
| @@ -21,8 +21,6 @@ | |||
| formatter = pkgs.nixpkgs-fmt; | |||
|
|
|||
| devShells.default = pkgs.mkShell { | |||
| inputsFrom = [ inputs'.holonix.devShells ]; | |||
There was a problem hiding this comment.
This was wrong and should have been
- inputsFrom = [ inputs'.holonix.devShells ];
+ inputsFrom = [ inputs'.holonix.devShells.default ];When you correct this, you end up pulling in everything from the base shell twice because we're also specifying packages. So we need to choose between these two options.
The idea was to keep this Holonix flexible, so I prefer removing the inputsFrom so that people can choose what to include in their dev shell
There was a problem hiding this comment.
I see, will remove this from the scaffolded nix flake, had actually modified it to the snippet below. In ref to holochain/scaffolding#365
inputsFrom = [ inputs'.holonix.devShells.default ];
templates/rust-stable/flake.nix
Outdated
| in | ||
| pkgs.mkShell { | ||
| packages = [ | ||
| rust |
There was a problem hiding this comment.
Provides a locally-defined Rust instead of the one from Holonix
templates/rust-stable/flake.nix
Outdated
There was a problem hiding this comment.
Name this folder custom-rust and the custom one custom-holochain?
There was a problem hiding this comment.
That'd be a nice pattern, done!
Co-authored-by: Jost Schulte <jost.schulte@protonmail.com>
ThetaSinner
force-pushed
the
allow-rust-to-be-provided-for-app-development
branch
from
77e9754 to
bca5e49
Compare
ThetaSinner
deleted the
allow-rust-to-be-provided-for-app-development
branch
No description provided.