Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dna properties on install #135

Merged
merged 6 commits into from
Jul 2, 2022
Merged

add dna properties on install #135

merged 6 commits into from
Jul 2, 2022

Conversation

JettTech
Copy link
Contributor

@JettTech JettTech commented Jun 29, 2022

Updates:

  • exposes the optional properties field from RegisterDnaRequest when installing dnas through addPlayerWithHapp.

@JettTech JettTech changed the title add dna properties on install; dedup add dna properties on install Jun 29, 2022
@JettTech JettTech marked this pull request as ready for review June 29, 2022 08:45
@JettTech JettTech requested a review from jost-s June 29, 2022 08:45
@JettTech JettTech requested review from jost-s and removed request for jost-s June 29, 2022 10:52
Copy link
Contributor

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you! Particularly for the concise deduping of DNA registering.

Please delete hc-utils, that looks like an empty file. And package-lock doesn't need to be updated since you didn't upgrade or install anything.

Ah, please execute npm run lint.

ts/src/types.ts Show resolved Hide resolved
@JettTech JettTech requested a review from jost-s July 1, 2022 02:24
Copy link
Contributor

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jost-s jost-s merged commit 50eff0f into develop Jul 2, 2022
@jost-s jost-s deleted the feature/add-dna-properties branch July 2, 2022 02:58
jost-s added a commit that referenced this pull request Jul 2, 2022
* Update CHANGELOG.md

* Fix/conductor logs (#125)

fix(local-conductor): log conductor msgs as info

* feat(common): add optional timeout to zome call (#130)

* docs(readme): mention log level env var

* fix(local): log conductor startup only once

* chore(changelog): update and bump version

* build(deps): bump smallvec from 1.6.0 to 1.8.0 in /crates/trycp_server (#127)

Bumps [smallvec](https://github.com/servo/rust-smallvec) from 1.6.0 to 1.8.0.
- [Release notes](https://github.com/servo/rust-smallvec/releases)
- [Commits](servo/rust-smallvec@v1.6.0...v1.8.0)

---
updated-dependencies:
- dependency-name: smallvec
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(local): log conductor output at debug level (#132)

* chore(changelog): update and bump version

* fix(local): print log as string

* ci(test): only run on PR

* add dna properties on install; dedup

* add dna properties on install - trycp; add to `addPlayerWithHapp`

* make option

* add missing field

* update docs, manage non-array case

* clean up

* refactor(common): mark register dna req opts internal

* chore(build): update changelog & bump version

* feat(common): add dna properties on install (#135)

* add dna properties on install; dedup

* add dna properties on install - trycp; add to `addPlayerWithHapp`

* make option

* add missing field

* update docs, manage non-array case

* clean up

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jetttech <ldjetton21@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants