Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[p5.js 2.0] Matrix move to math folder #1

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

holomorfo
Copy link
Owner

@holomorfo holomorfo commented Oct 11, 2024

Matrix move to math folder

Branched from 7277
Resolves #processing#6765 (Partially)

Changes:
Migrate Matrix component from webgl folder to the math folder, created function createMatrix so users can consume in the same way as for createVector

PR Checklist

  • npm run lint passes
  • Inline documentation is included / updated. IN PROGRES
  • Unit tests are included / updated (Didn't modify any existing test, but verified that the changes don't impact existing tests)

CC: @limzykenneth @davepagurek @Qianqianye

@holomorfo holomorfo marked this pull request as ready for review October 11, 2024 05:02
@holomorfo holomorfo self-assigned this Oct 11, 2024
@limzykenneth
Copy link
Collaborator

@holomorfo You can file the changes directly against the dev-2.0 branch if you like, if there are merge conflicts we can resolve it so no worries about that.

@holomorfo holomorfo merged commit dec0bd3 into Vector-nd Oct 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants