-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kargo Integration #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The secret needs to be manually created right now as per https://docs.kargo.io/how-to-guides/managing-credentials/#github-app-authentication
Manage the Project resource similar to namespaces. ❯ k get project -A NAME READY STATUS AGE dev-bank-backend True Project is initialized and ready for use 15s dev-bank-frontend True Project is initialized and ready for use 15s dev-bank-security True Project is initialized and ready for use 15s prod-bank-backend True Project is initialized and ready for use 15s prod-bank-frontend True Project is initialized and ready for use 15s prod-bank-security True Project is initialized and ready for use 15s stage-bank-backend True Project is initialized and ready for use 15s stage-bank-frontend True Project is initialized and ready for use 15s stage-bank-security True Project is initialized and ready for use 15s test-bank-backend True Project is initialized and ready for use 15s test-bank-frontend True Project is initialized and ready for use 15s test-bank-security True Project is initialized and ready for use 15s
❯ k get warehouse -A NAMESPACE NAME SHARD AGE dev-bank-frontend frontend 91m prod-bank-frontend frontend 91m stage-bank-frontend frontend 91m test-bank-frontend frontend 91m
This approach writes a kustomization.yaml file to build plan output directory. Kargo edits this kustomization.yaml file with the image tag to promote.
We need to re-orient the bank holos projects to consolidate down to bank-security, bank-backend, and bank-web from the 12 we have today. This will align to Kargo's concept of a project which spans multiple namespaces.
A Kargo Project spans multiple namespaces. The previous Holos model of mapping 1 project to 1 env+team doesn't align well with Kargo. This patch addresses the problem by breaking the bank of holos stack into 3 projects, one for security, one for the backend, one for the frontend web. Each project contains multiple namespaces to support Kargo promotion. One additional namespace is managed for adoption as a Kargo's Project. - [x] time ./scripts/full-reset - 1min 16s - [x] 3 Namespaces with same names and the adoption label deploy/clusters/workload/projects/bank-security/components/namespaces/namespaces.gen.yaml - [x] 3 Kargo Projects bank-security, bank-backend, bank-web. deploy/clusters/workload/projects/bank-security/components/projects/projects.gen.yaml - [x] Stages deployed to the correct namespace. - [x] ArgoCD comes up from full-reset in a synced state. - Yes, except for the Kargo stage branches, which we expect to be out of sync. ArgoCD Application Authorization failed to run step "argocd-update": error getting Argo CD Application "bank-web-dev-frontend" in namespace "argocd": Argo CD Application "bank-web-dev-frontend" in namespace "argocd" does not permit mutation by Kargo Stage dev-frontend in namespace bank-security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: holos-run/holos#372