Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize pyodide based docs #314

Merged
merged 29 commits into from
Sep 12, 2024
Merged

Parallelize pyodide based docs #314

merged 29 commits into from
Sep 12, 2024

Conversation

philippjfr
Copy link
Contributor

Allows parallelization of pyodide based docs by:

  • Storing a state dictionary per document
  • Writing resources out to disk (guarded by a lockfile) to ensure we can gather all required resources
  • Making the subprocesses daemons

nbsite/pyodide/__init__.py Outdated Show resolved Hide resolved
nbsite/cmd.py Outdated Show resolved Hide resolved
nbsite/cmd.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious: Is the processing still needed when using sphinx parallelization?

nbsite/pyodide/__init__.py Show resolved Hide resolved
nbsite/pyodide/__init__.py Outdated Show resolved Hide resolved
nbsite/pyodide/__init__.py Outdated Show resolved Hide resolved
nbsite/pyodide/__init__.py Show resolved Hide resolved
philippjfr and others added 2 commits September 10, 2024 11:34
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
@philippjfr
Copy link
Contributor Author

I'm curious: Is the processing still needed when using sphinx parallelization?

Yes, absolutely. Each pyodide execution environment expects a clean slate. In theory we could try to clean up state but that seems very prone to issues.

nbsite/pyodide/__init__.py Show resolved Hide resolved
nbsite/pyodide/__init__.py Outdated Show resolved Hide resolved
nbsite/pyodide/__init__.py Show resolved Hide resolved
nbsite/pyodide/__init__.py Show resolved Hide resolved
@philippjfr philippjfr merged commit 6e7a375 into main Sep 12, 2024
5 checks passed
@philippjfr philippjfr deleted the parallelize_pyodide branch September 12, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants