Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multichannel Timeseries: don't rely on custom downloads #448

Open
maximlt opened this issue Nov 19, 2024 · 2 comments
Open

Multichannel Timeseries: don't rely on custom downloads #448

maximlt opened this issue Nov 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@maximlt
Copy link
Contributor

maximlt commented Nov 19, 2024

For reasons unrelated to examples.holoviz.org (see #418 (comment)), @droumis has implemented inlined downloads (via pooch) on top of anaconda-project downloads for the Multichannel Timeseries example. I would prefer not to include that sort of code, we cannot guarantee users they will be able to run the notebooks in any other way than via anaconda-project. It's not that I have a passion for this tool, it's just that this whole project is too big to offer custom runtime for each and every example.

@maximlt maximlt added the bug Something isn't working label Nov 19, 2024
@droumis
Copy link
Contributor

droumis commented Nov 19, 2024

Multichannel Timeseries: don't rely on custom downloads #448

I don't think this title is a fair assessment of the situation. The example does not "rely" on custom downloads. Before this issue was created, the example was already using anaconda-project for all the data downloads. The only extra layer is that in the notebook, there is a check if the data is downloaded to the location that anaconda-project should download the data to, and if the data is not present, it uses pooch to do so.

@droumis
Copy link
Contributor

droumis commented Nov 19, 2024

My solution ensures that a user does not require anaconda-project, but anaconda-project is still the encouraged method of running the project, per the website's instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants