Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmentation fault when rendering line #328

Closed
jbcrail opened this issue Apr 27, 2017 · 0 comments
Closed

Segmentation fault when rendering line #328

jbcrail opened this issue Apr 27, 2017 · 0 comments
Assignees
@jbcrail

Comments

@jbcrail
Copy link
Contributor

jbcrail commented Apr 27, 2017

As noted by @philippjfr, the off-by-one PR introduced a segmentation fault.

See the comments in PR #318 for more details.
jbcrail added a commit to jbcrail/datashader that referenced this issue Apr 27, 2017
@jbcrail
Adjust line to account for exclusive upper bounds
37a0a8e 
When extending a line, I decremented the upper bounds for both x and y.

Fix holoviz#328
@jbcrail jbcrail mentioned this issue Apr 27, 2017
Merged
@jbcrail jbcrail self-assigned this Apr 27, 2017
@jbcrail jbcrail mentioned this issue Apr 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbcrail jbcrail

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbcrail @jbednar