Tornado pinning for tests #741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis has passed this time. I've now restarted the failing build in #734 to see if the issue has been resolved somehow... |
|
Restarting the failing build seems to have fixed it (presumably tornado is now being pinned elsewhere). At there no longer seems to be an issue, I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR trying to fix the tests in #734:
Related issues:
holoviz/holoviews#3560
jupyter/nbconvert#894
The real fix is an nbconvert release but we can't count on that happening soon. My first commit is just to check that nbsmoke is consistently failing - after that I'll pin tornado to get the tests passing again.