Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a GeohashInterface #373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added a GeohashInterface #373

wants to merge 1 commit into from

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 30, 2019

Implements #372

Screen Shot 2019-10-30 at 2 34 02 PM

We could separately add support for a pandas DataFrame with a 'geohash' column or more simply upgrade such a DataFrame to a geopandas DataFrame by converting the 'geohash' column to a 'geometry' column.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Needs some examples in the docs, including the above example but also instantiating points with the centroid of the geohash rectangle, and indicating that the dependent library needs to be installed.

def geohash_to_polygon(geo):
"""
:param geo: String that represents the geohash.
:return: Returns a Shapely's Polygon instance that represents the geohash.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:return: Returns a Shapely's Polygon instance that represents the geohash.
:return: Returns a Shapely Polygon instance that represents the geohash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants