Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style pickling is currently broken #263

Closed
jlstevens opened this issue Sep 10, 2015 · 2 comments
Closed

Style pickling is currently broken #263

jlstevens opened this issue Sep 10, 2015 · 2 comments
Assignees
Labels
type: bug Something isn't correct or isn't working
Milestone

Comments

@jlstevens
Copy link
Contributor

The pickling of styles is currently not working, presumably since we updated HoloViews to support multiple backends. Note that using the regular pickle module, you can still unpickle your data even if the styles aren't correctly restored.

I also propose adding a few pickle files in the tests directory so we can add some unit tests in order to make sure it doesn't break again without us noticing it.

@jlstevens jlstevens added the type: bug Something isn't correct or isn't working label Sep 10, 2015
@philippjfr philippjfr added this to the v1.4.0 milestone Sep 11, 2015
@philippjfr philippjfr mentioned this issue Nov 10, 2015
42 tasks
@jlstevens
Copy link
Contributor Author

Most of the issues have been addressed in PR #307 (now merged) which involved the style system across backends in general (and not just pickles).

I'll add some unit tests specifically for pickling and then if they pass, I can close this issue.

@jlstevens
Copy link
Contributor Author

I've added two fairly extensive unit tests (cross backend) in 987f907 and they are passing.

With that I can finally close this issue! I'm very pleased that not only is the bug fixed, but we now have the ability to style the same object across backends. I think this could prove very useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

No branches or pull requests

2 participants