Cross backend style fixes #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing because style inheritance doesn't seem to be working for one example in the Pandas Conversion tutorial. It seems to be an issue with style inheritance even though there are unit tests for this and simple tests work fine for me in the notebook. Strange... |
|
I can confirm it is the last commit that stops inheritance working in this example. However, I need that commit to get the behavior we now want... |
|
Sorry about the accidental merge! The latest version of magit has a 'push quickly' option that went and did this... :-( |
|
On the plus side, the tests all passed so maybe it was time to merge these fixes anyway. :-) I'm now going to try and add some new unit for cross backend styling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address the problems with style pickling ahead of the 1.4 release and to allow a single object to retain styling across backends.
Edit: Really pickling is only part of the issue so I've changed to the title to reflect that the fix is for styling across backends in general.