-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dimension.label replacing global alias state #1083
Conversation
2770e78
to
b759400
Compare
This is now passing without any major issues. This needs a lot more unit tests still and @jlstevens promised to write a short tutorial but we're both very happy with how this will work out. |
Looks good to me. Some examples of usage would be good. |
Yes, those should be part of the tutorial. I'd actually like to suggest to broaden the scope of that tutorial to discuss Dimensions in general, with a significant section devoted to Another thing I've done in this PR is using |
Thanks @philippjfr! I'll shortly write up a notebook tutorial describing aliases, |
I now have part of a Dimensions tutorial but I would like to work on #843 before continuing work on it. I am happy with this PR and would like to merge it now. Are you ok with me adding the Dimensions notebook to a different PR? |
Sure, let's see how it goes. Better to get it in early to find issues. |
Addresses #1001 and supersedes #1075.