Correctly sync shared datasources #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
tag: backend: bokeh
type: bug
philippjfr
commented
Apr 9, 2017
holoviews/plotting/bokeh/plot.py
Outdated
| def update_frame(self, key, ranges=None): | ||
| """ | ||
| Update the internal state of the Plot to represent the given | ||
| key tuple (where integers represent frames). Returns this | ||
| state. | ||
| """ | ||
| source_cols = self.handles.get('source_cols', {}) |
philippjfr
commented
Apr 9, 2017
| @@ -1224,6 +1224,45 @@ def test_shared_axes_disable(self): | |||
| self.assertEqual((x_range.start, x_range.end), (-.5, .5)) | |||
| self.assertEqual((y_range.start, y_range.end), (-.5, .5)) | |||
|
|
|||
| def test_layout_shared_source_synced_update(self): | |||
| hmap = HoloMap({i: Dataset({chr(65+j): np.random.rand(i+2) | |||
There was a problem hiding this comment.
Add comments and check source_cols is A, B, C, D
|
Happy to merge once you've addressed those two comments. |
philippjfr
force-pushed
the
shared_source_fix
branch
from
92fc617
to
380d263
Compare
|
Addressed the comments, ready to merge when tests pass. |
|
Had to restart the tests due to transients but they are all passing now. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a context manager which ensures that while updating a composite plot any datasources shared among multiple subplots are appropriately synced, avoiding warnings and bokehjs errors. Fixes #1135.