Applied formatting to bokeh datetime hover tool labels #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shame it is such a pain but I agree it needs to be fixed. File an issue if you think there may be cleaner way to handle this in future. In the meantime I'll merge this PR given that the tests are passing. |
Not until bokeh do something about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #1261 datetimes in the hover tool should be formatted correctly. This has annoyed me myself a fair bit. Currently the only approach to make this work is to send the formatted strings as a column in the ColumnDataSource as outlined here, in future we can hopefully use JS datetime formatting to support this. I do think this is an important feature (it's visible in a number of my demos like the StockExplorer) and should make it into 1.7.
See bokeh/bokeh#1239 for status of a more convenient/efficient mechanism for this.