-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added simpler .hist example #1663
Conversation
That is a worthwhile example to add. Best we wait to see which of those matplotlib bugs can be fixed before merging. |
Will see, dealing with adjoints more generally in matplotlib has been a longstanding issue (see #1033). |
@philippjfr Should we merge despite the weird matplotlib output? |
I'll see if I can deal with the wrong colormapping at least. Doubt I'll be able to fix the sizing issue easily. |
@jbednar Would you mind updating this PR by setting an explicit range for the x and y dimensions? For now matplotlib won't normalize the points and histogram together so you end up with different scales. |
It sounds like you know what's needed; can you just push what you suggest to the PR? |
Done. @jlstevens ready to merge when tests pass. |
Looks good and the tests are passing. Merging. |
The Histogram page in the Reference Gallery didn't have a simple example of using '.hist()', which is typically much more convenient than the complex example shown. Added this simple example:
Works fine for Bokeh, but in mpl there is a strange colormap:
The last example on that page (not really modified in this PR) is also aligned and sized very strangely for matplotlib, though it works fine for bokeh: