Periodic utility now stops when StopIteration is raised #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests pass but that might not tell us much... |
|
This seems safe to me, I'd also like to investigate removing that catch-all exception handler, but not in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is hopefully a simple fix to stop the periodic utility automatically when
StopIterationis raised e.g when using a generator in aDynamicMap.I understand why you might want to skip
KeyErroringet_plot_framebut I don't get why it is blocking all exceptions and simply printing them. For now I am just catchingStopIterationspecifically and re-raising those exceptions.@philippjfr Why can't exceptions other than
KeyErrorbe left alone and allowed to bubble up?