Allow defining CompositeElementPlot glyph order #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
tag: backend: bokeh
tag: component: plotting
type: bug
|
Tests passed and this is a bug fix holding up other development work, merging. |
Merged
|
We never really decided on a policy on doctests. I am certainly in favor of them when they make sense and don't dominate the docstring. Certainly not complaining about the usage here which does seems appropriate... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the glyph ordering was not applied correctly, which is causing issues in #2155. I've now fixed that and moved the ordering out to a separate function with a doctest.