Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bokeh SideHistogram with (non)inverted axis #2285

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 30, 2018

When plotting an adjoint histogram in bokeh the dynamic color range functionality was not set up to handle an adjoint plot at the top.

screen shot 2018-01-30 at 10 27 32 pm

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: backend: bokeh labels Jan 30, 2018
@philippjfr philippjfr added this to the v1.10 milestone Jan 30, 2018
@jlstevens
Copy link
Contributor

Thanks for this. I tested it out on a number of fairly complex examples and it does seem to be fixed. Happy to merge if you think this PR is ready.

@philippjfr
Copy link
Member Author

philippjfr commented Jan 30, 2018

Seems to need new test data:

[{'values_changed': {"root['roots']['references'][27]['attributes']['code']": {'new_value': u"
 color_mapper.low = cb_data['geometry']['y0'];
 color_mapper.high = cb_data['geometry']['y1'];
 source.change.emit()
 main_source.change.emit()
 ", 'old_value': u"
 color_mapper.low = cb_data['geometry']['y0'];
 color_mapper.high = cb_data['geometry']['y1'];
 source.change.emit(undefined)
 main_source.change.emit(undefined)
 ", 'diff': u"--- 
+++ 
@@ -1,6 +1,6 @@
 
 color_mapper.low = cb_data['geometry']['y0'];
 color_mapper.high = cb_data['geometry']['y1'];
- source.change.emit(undefined)
- main_source.change.emit(undefined)
+ source.change.emit()
+ main_source.change.emit()
 "}}}]

@philippjfr
Copy link
Member Author

Hmm, I just got used to putting those undefined in because it's a TypeScript error, can remove them again and it should pass.

@jlstevens
Copy link
Contributor

Tests are passing. Merging.

@jlstevens jlstevens merged commit cc0db76 into master Jan 31, 2018
@philippjfr philippjfr modified the milestones: v1.10, 1.9.3 Feb 11, 2018
@philippjfr philippjfr deleted the adjoint_hist_invert branch February 11, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: backend: bokeh type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants