Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size_index to graphs #3101

Closed
wants to merge 1 commit into from
Closed

Add size_index to graphs #3101

wants to merge 1 commit into from

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Oct 24, 2018

Try to address #3097, but I'm not really sure what I'm doing; just copying a bunch of code from the other scripts.

Still useless too because I can't seem to figure out where it only takes the first three(?) columns and converts it to ['index', 'x', 'y'](?) instead of ['index', 'x', 'y', 'test'] so size_index/color_index only works on either 'index', 'x' or 'y'... (I think if the three column restriction is removed, it'll help complement the fix to the image hover_col limit too(?) holoviz/geoviews#242 besides changing bounds=(1, None)))

image

@philippjfr
Copy link
Member

I'd hold off on this, #2152 should already allow for this.

@ahuang11
Copy link
Collaborator Author

Okay. Still wondering where in the code are the columns changed to ['x', 'y', 'index']

@philippjfr
Copy link
Member

That does sound like an issue, will have to look into it.

@philippjfr
Copy link
Member

I'll close since I'll be addressing any issues that crop up in the ops PR.

@philippjfr philippjfr closed this Nov 8, 2018
@philippjfr philippjfr deleted the graph_size_index branch April 29, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants