Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plotly backend to support plotly.py version 3 #3194

Merged
merged 15 commits into from
Nov 25, 2018

Commits on Nov 24, 2018

  1. 'k' is not a valid plotly color string, use 'black' instead

    's' is not a valid plotly symbol string, use 'circle' instead
    'plasma' is not a valid plotly colorscale, use 'viridis' instead
    jonmmease committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    4c33fc5 View commit details
    Browse the repository at this point in the history
  2. Rename global plotly library object in JavaScript

    The global plotly library object was renamed from 'Plotly' to '_Plotly'
    in plotly.py 3.4.0 to avoid a naming conflict when a Jupyter Notebook
    heading contained the text 'Plotly'
    
    See:
    plotly/plotly.py#816
    plotly/plotly.py#1250
    jonmmease committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    53caa47 View commit details
    Browse the repository at this point in the history
  3. Replace use of deprecated graph object classes

    Graph objects are now structured hierarchically, so go.Marker was
    deprecated in favor of go.layout.Marker.  The use of these classes
    is fully optional, and they can be replaced by plain dict instances in
    cases where local validation, tab completions, and docstrings aren't
    needed.
    jonmmease committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    a25e1d8 View commit details
    Browse the repository at this point in the history
  4. The figure.data property is now a tuple rather than a list, so it

    cannot be mutated in place. Instead, the add_traces method is used
    to append additional traces to the figure.
    jonmmease committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    d1fb68b View commit details
    Browse the repository at this point in the history
  5. Object arrays (like annotations) are now stored as tuples

    rather than lists so they cannot be extended in place.
    The += operator can be used instead to replace the object array with
    an extended version of itself.
    jonmmease committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    8b7ecf0 View commit details
    Browse the repository at this point in the history
  6. Graph objects are no longer dict subclasses, they are wrappers around

    dict instances with some dict-like methods. The to_plotly_json method
    is used to convert a graph object into a Python dict.
    jonmmease committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    8bf678d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6bb729d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d9c8864 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    80b3369 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7d99c64 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b454ba4 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    322527a View commit details
    Browse the repository at this point in the history
  13. When exporting to standalone html the plotly library is loaded as Plotly

    but when loaded into the notebook it is loaded as _Plotly.
    
    (before this commit figures rendered properly in the jupyter notebook
    but an error was raised when output to an HTML file that _Plotly is
    not defined)
    jonmmease committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    b7ebc6c View commit details
    Browse the repository at this point in the history
  14. Run conda env update with travis_wait command to (hopefully) avoid CI…

    … timeout.
    
    See https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
    
    Prior intermittent CI error:
    ```
    ...
    $ conda env update -n holoviews -q -f environment.yml
    Solving environment: ...working... done
    Preparing transaction: ...working... done
    Verifying transaction: ...working... done
    Executing transaction: ...working... dbus post-link :: /etc/machine-id not found ..
    dbus post-link :: .. using /proc/sys/kernel/random/boot_id
    No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
    ```
    jonmmease committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    e5a4d4f View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2018

  1. Configuration menu
    Copy the full SHA
    ed65c14 View commit details
    Browse the repository at this point in the history