WIP: Replace plotly HTML rendering with Panel #3837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widgets not working yet
philippjfr
reviewed
Jul 21, 2019
|
|
||
| if LooseVersion(plotly.__version__) < '3.4.0': | ||
| raise VersionError( | ||
| "The plotly extension requires a plotly version >=3.4.0, " | ||
| "please upgrade from plotly %s to a more recent version." | ||
| % plotly.__version__, plotly.__version__, '3.4.0') | ||
|
|
||
| pn.extension("plotly") | ||
|
|
There was a problem hiding this comment.
Should remove this, importing the plotting module shouldn't load the extension.
philippjfr
reviewed
Jul 21, 2019
| @@ -16,13 +16,17 @@ | |||
| from .tabular import * # noqa (API import) | |||
| from ...core.util import LooseVersion, VersionError | |||
| import plotly | |||
| import panel as pn | |||
There was a problem hiding this comment.
Suggested change
| import panel as pn | |
| import panel.models.plotly # noqa |
|
Looks like a good start. Will probably have to add something to either the extension itself or |
This was referenced Jul 24, 2019
|
Superseded by #3850 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough initial prototype of using Panel to display plotly figures in HoloViews. The goal is to combine this with #3836 and holoviz/panel#529 to support interactive streams with the Plotly backend.
If successful, this would become the new foundation for the work started in #3316 to support
Selection1DandRangeXYstreams with the Plotly backend.