-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotly: Assorted enhancements to support streams examples #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the Panel HoloViews model for all HTML format requests (not only for the hv objects with widgets) * Don't call `_figure_data` with 'html' format, handle these through Panel * Remove fmt='html' logic from _figure_data methods. `as_script` arg still supported to return static images as HTML fragments, but since there is no associated JavaScript in this case the method no longer returns a tuple when `as_script=True`. * Initialize appropriate panel extensions in load_nb methods Remove unneeded notebook initialization code * Remove unneeded HTML/JS code and templates from Bokeh and Plotly renderers * Fix plotly save to SVG encoding
Just in case Pane's default backend is configured differently from HoloViews'
so that we can reuse it for the plotly backend
Support for RangeXY, RangeX, RangeY, BoundsXY, BoundsX, BoundsY, and Selection1d
when updating DynamicMaps from Python
Panel handles all of this for us, so we don't want to create or update any comms directly.
- Add plotly test for updating DynamicMap from streams using Panel - Add interactive streams test using Panel
Use this in plotly renderer to remove the new '_id' internal key before giving the figure dictionary to the user.
* Use the Panel HoloViews model for all HTML format requests (not only for the hv objects with widgets) * Don't call `_figure_data` with 'html' format, handle these through Panel * Remove fmt='html' logic from _figure_data methods. `as_script` arg still supported to return static images as HTML fragments, but since there is no associated JavaScript in this case the method no longer returns a tuple when `as_script=True`. * Initialize appropriate panel extensions in load_nb methods Remove unneeded notebook initialization code * Remove unneeded HTML/JS code and templates from Bokeh and Plotly renderers * Fix plotly save to SVG encoding
…eams # Conflicts: # holoviews/plotting/bokeh/renderer.py # holoviews/plotting/mpl/renderer.py # holoviews/plotting/plotly/renderer.py # holoviews/plotting/renderer.py
…t_state This allows us to use magic underscore notation inside the figure dictionary
This is required in order to use magic underscore notation
Instead, strip `line_` prefix if property is applied to a `line` container. This way we can use `line_width` as property for other elements.
…ations. Previously elements could only be represented by traces.
- Bounds - Box - VLine - HLine - Ellipse
Also add utility function to check properties, considering magic underscore notation
This keeps figure layout from changing between dynamic updated.
This allows specifying the spacing between plots in a size-independent way.
…ng Plotly notebook
philippjfr
force-pushed
the
plotly_streams_examples
branch
from
August 17, 2019 12:10
9295d20
to
02e6b20
Compare
philippjfr
force-pushed
the
plotly_streams_examples
branch
from
August 17, 2019 12:17
02e6b20
to
c6af575
Compare
philippjfr
force-pushed
the
plotly_streams_examples
branch
from
August 17, 2019 21:59
d750bfe
to
4e9abcb
Compare
Thanks for tackling this merge @philippjfr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopens #3880 against master