Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linked selection improvements #4437

Merged
merged 1 commit into from
May 27, 2020
Merged

Linked selection improvements #4437

merged 1 commit into from
May 27, 2020

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented May 25, 2020 •
edited
Loading

  • Fixes empty lasso selects causing errors during selection

@philippjfr philippjfr force-pushed the linked_selection_improvements branch from a9576b7 to eacbdaa Compare May 26, 2020 19:02
@philippjfr philippjfr force-pushed the linked_selection_improvements branch from eacbdaa to 92549df Compare May 27, 2020 20:42
@philippjfr
Copy link
Member Author

Dropping this for now and merging just the lasso fix:

  • Removes special handling of Histogram linked selections, the idea was nice but:
    • Selecting on the bin height is not that useful
    • np.digitize on the input on every selection is fairly expensive
    • It is very complex and brittle code
    • The digitize operation is not supported by a cuDF

@philippjfr philippjfr merged commit b31f6ba into master May 27, 2020
@philippjfr philippjfr deleted the linked_selection_improvements branch April 25, 2022 14:40
@maximlt maximlt mentioned this pull request Sep 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbednar jbednar jbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippjfr @jbednar