Remove all use of cyordereddict. #4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about Python 2.7? |
|
Thanks for this PR! I totally forgot that HoloViews ever tries to use cyordereddict and I am happy to see it go away... |
|
Also looks good to me, ready to merge? |
philippjfr
reviewed
Sep 24, 2020
|
We won't be supporting Python 2 for that much longer. Personally, I don't think it would be a big issue to remove |
It is obsolete and even its upstream declares that the OrderedDict in the standard library is superior to it (since 3.5).
|
Thanks @mcepl! I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is obsolete and even its upstream declares that the OrderedDict in the standard library is superior to it (since 3.5).