-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy index values to host for iteration #4646
Conversation
This still leaves the following broken cudf tests, most (all?) of which seem to relate to current lack of string support in cudf:
I'm not sure how you might like to handle this since it seems most or all of these tests are inherited from a test base class, so I am not sure the simplest way to disable them. |
There are a few failing tests above with:
And I am not sure those are string-related. Might be actual failures, but someone more knowledgeable than me will have to comment. |
@philippjfr @jlstevens the test failures appear unrelated? |
Yeah, seeing those on another PR as well. Will check out this PR this evening on my GPU machine. |
Merging and will do a round of testing on my GPU machine in a minute. |
cc @philippjfr @jlstevens
This PR adds some missing
.values_host
calls necessary on cudf indices before iteration. It fixes the following broken tests: