Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dask/cudf histogram fixes #4691

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Dask/cudf histogram fixes #4691

merged 3 commits into from
Nov 19, 2020

Conversation

jonmmease
Copy link
Collaborator

This PR has two small fixes for displaying histograms using dask and cudf.

  • First, the plotly histogram plot was passing Dask arrays into the Plotly Figure dictionary which plotly.py doesn't handle.
  • Second, the histogram operation code was still using the deprecated normed argument in one place. Numpy still supports this with a runtime deprecation warning, but cupy doesn't. The replacement is the density kwarg, which we were already using several places in the same function so I don't think backward compatibility should be affected at all. Also, the normed kwarg has been deprecated in numpy for a long time now (since 1.6.0)

Do these make sense @philippjfr ?

@jonmmease jonmmease added this to the v1.14.0 milestone Nov 19, 2020
@philippjfr
Copy link
Member

I've got various cuDF fixes I still need to push up including a fix for normed and the Ibis PR completely refactors the histogram operation. So maybe drop the normed change for now.

@jonmmease
Copy link
Collaborator Author

Sure thing! Thanks for working on all that

@philippjfr philippjfr merged commit 900718e into master Nov 19, 2020
@philippjfr
Copy link
Member

Thanks @jonmmease!

@philippjfr philippjfr deleted the histogram_fixes branch April 25, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants