Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for index based linked selections #4776

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Fixes for index based linked selections #4776

merged 4 commits into from
Mar 2, 2021

Conversation

philippjfr
Copy link
Member

Fixes two issues with index based linked selections:

  1. Ensures empty selection is not applied
  2. Ensures that index cols are present on the selected element

Example:

import hvplot.pandas
from holoviews.selection import link_selections
from bokeh.sampledata.autompg import autompg

scatter = autompg.hvplot.scatter('weight', 'accel')
table = autompg.hvplot.table()

link_selections(scatter + table, index_cols=['name', 'yr'])

Screen Shot 2021-01-03 at 1 36 57 PM

@jlstevens
Copy link
Contributor

jlstevens commented Feb 3, 2021

@philippjfr Would you like me to rebase this PR so we can get updated test results? The errors look like they may well be related to these changes (which sound relatively important given the short diff) but I think a rebase wouldn't hurt to try anyway...

@philippjfr
Copy link
Member Author

I rebased it a day ago, the error is real.

@philippjfr philippjfr added this to the v1.14.2 milestone Mar 2, 2021
@philippjfr philippjfr merged commit 8ea52d2 into master Mar 2, 2021
@philippjfr philippjfr deleted the ls_index branch April 25, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants