Updated operation streams parameter definitions #4825
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the Large Data notebook on current master revealed a param bug (holoviz/param#455) where
decimate
was failing despite having a valid declaration.The issue is that #4818 generalized the allowable values for the
streams
parameter but the param bug referenced above means that all operations need to use the sameClassSelector
definition even if the current declaration is a valid subset of what is accepted by the base class (i.eparam.List
orparam.Dict
).I realize that I probably updated a bunch of parameter definitions in #4818 even though it wasn't strictly necessary (if the param bug wasn't an issue).
It is important to fix this param issue as all user defined operations will also be affected: users shouldn't have to update their
streams
parameter definitions.