Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dask TriMesh rasterization #4935

Merged
merged 4 commits into from
May 18, 2021
Merged

Fix dask TriMesh rasterization #4935

merged 4 commits into from
May 18, 2021

Conversation

philippjfr
Copy link
Member

Previously the vertex and simplex data was always converted to pandas so the dask codepath in datashader was never exercised.

@jlstevens
Copy link
Contributor

Looks good to me!

Seems conda on python 3.6 windows is running out of memory:

Solving environment: ...working... failed with initial frozen solve. Retrying with flexible solve.

Solving environment: ...working... failed with repodata from current_repodata.json, will retry with next repodata source.

Collecting package metadata (repodata.json): ...working... done

*** picosat: out of memory in 'resize'
Solving environment: ...working... TaskError - taskid:develop_install
Command error: 'conda install -y  -c pyviz/label/dev -c bokeh/label/dev -c conda-forge "param >=1.9.3,<2.0" "numpy >=1.0" "pyviz_comms >=0.7.4" "panel >=0.8.0" "colorcet" "pandas >=0.20.0" "nose" "mock" "flake8" "coveralls" "path.py" "matplotlib >=3" "nbsmoke >=0.2.0" "nbconvert <6" "twine" "rfc3986" "keyring" "ipython >=5.4.0" "notebook" "matplotlib >=3" "bokeh >=1.1.0" "networkx" "pillow" "xarray >=0.10.4" "plotly >=4.0" "dash >=1.16" "streamz >=0.5.0" "datashader >=0.11.1" "ffmpeg" "cftime" "netcdf4" "dask" "scipy" "shapely" "scikit-image" "spatialpandas" "pyarrow" "ibis-framework >=1.3" "nose" "mock" "flake8" "cov

And coveralls will be fixed by adding a unit test.

@philippjfr
Copy link
Member Author

Ready to merge.

@philippjfr philippjfr merged commit bc54880 into master May 18, 2021
@philippjfr philippjfr added this to the v1.14.4 milestone May 18, 2021
@philippjfr philippjfr deleted the dask_trimesh_rasterize branch April 25, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants