Ensure batched plots in Overlays are recognized as overlaid #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
reviewed
Nov 3, 2016
| style=style, uniform=self.uniform, | ||
| zorder=zorder, **{k: v for k, v in | ||
| self.handles.items() if k in | ||
| self._passed_handles}) |
There was a problem hiding this comment.
Formatting could be improved starting with **.
There was a problem hiding this comment.
Yea auto-indenting made a mess here.
|
Looks good to me. |
philippjfr
force-pushed
the
batched_overlaid_bug
branch
from
52190b1
to
8bd833f
Compare
|
Looks good to me too. Merging. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous batched plots (i.e. NdOverlays of batchable Elements) that were themselves overlaid were not correctly registered as such causing them to override axis ranges, widths, heights etc. This fixes this behavior.