Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Application from panel.io.application, drop 3.9, and ruff #707

Merged
merged 7 commits into from
Sep 20, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Sep 20, 2024

@ahuang11 ahuang11 requested a review from philippjfr September 20, 2024 17:02
@ahuang11 ahuang11 changed the title import from applications Import Application from panel.io.applications Sep 20, 2024
@ahuang11 ahuang11 changed the title Import Application from panel.io.applications Import Application from panel.io.applicatio Sep 20, 2024
@ahuang11 ahuang11 changed the title Import Application from panel.io.applicatio Import Application from panel.io.application Sep 20, 2024
@ahuang11 ahuang11 changed the title Import Application from panel.io.application Import Application from panel.io.application and drop 3.9 Sep 20, 2024
@ahuang11
Copy link
Contributor Author

Discovered that Bokeh dropped 3.9 support, therefore Panel too, and so I also had to do drop it for Lumen holoviz/panel#6883

@ahuang11 ahuang11 changed the title Import Application from panel.io.application and drop 3.9 Import Application from panel.io.application, drop 3.9, and ruff Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 46.87500% with 17 lines in your changes missing coverage. Please review.

Project coverage is 56.02%. Comparing base (6ff1468) to head (50e53ef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lumen/ai/translate.py 0.00% 7 Missing ⚠️
lumen/sources/base.py 33.33% 2 Missing ⚠️
lumen/transforms/base.py 33.33% 2 Missing ⚠️
lumen/ai/agents.py 0.00% 1 Missing ⚠️
lumen/ai/assistant.py 0.00% 1 Missing ⚠️
lumen/command/__init__.py 0.00% 1 Missing ⚠️
lumen/command/ai.py 0.00% 1 Missing ⚠️
lumen/ui/base.py 0.00% 1 Missing ⚠️
lumen/views/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
- Coverage   56.04%   56.02%   -0.03%     
==========================================
  Files          98       98              
  Lines       11829    11828       -1     
==========================================
- Hits         6630     6627       -3     
- Misses       5199     5201       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 905ac36 into main Sep 20, 2024
11 checks passed
@philippjfr philippjfr deleted the fix_import branch September 20, 2024 21:04
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants