Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken link in gh-actions badge #2325

Merged
merged 2 commits into from
May 18, 2021
Merged

Fixed broken link in gh-actions badge #2325

merged 2 commits into from
May 18, 2021

Conversation

jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 17, 2021

Not sure what the intended link was but it isn't working right now so I'm proposing what I think was supposed to be the target...

@jlstevens
Copy link
Contributor Author

jlstevens commented May 17, 2021

hvplot uses: https://github.com/holoviz/hvplot/actions?query=workflow%3Atests and datashader uses https://github.com/holoviz/datashader/actions?query=workflow%3Atests so maybe that was the intent?

@philippjfr
Copy link
Member

Thanks, I think they actually changed the URL at some point.

@hoxbro
Copy link
Member

hoxbro commented May 17, 2021

Would it not be better to have it referencing the master branch? This can be done by appending?query=branch%3Amaster to both urls.

@philippjfr
Copy link
Member

Good suggestion @hoxbro. If you have the time @jlstevens we should do that everywhere.

@jlstevens
Copy link
Contributor Author

... we should do that everywhere.

I'm happy to update our main projects (and list the ones that I updated) but I'm not sure about everywhere as such. :-)

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once this links to the master branch as Hoxbro suggested.

README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #2325 (0425430) into master (5604328) will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2325      +/-   ##
==========================================
- Coverage   84.03%   83.78%   -0.25%     
==========================================
  Files         181      181              
  Lines       21946    21623     -323     
==========================================
- Hits        18442    18117     -325     
- Misses       3504     3506       +2     
Impacted Files Coverage Δ
panel/config.py 46.17% <0.00%> (-5.61%) ⬇️
panel/auth.py 36.21% <0.00%> (-3.30%) ⬇️
panel/pane/ipywidget.py 47.05% <0.00%> (-2.95%) ⬇️
panel/io/reload.py 63.95% <0.00%> (-2.72%) ⬇️
panel/tests/template/test_manual.py 59.13% <0.00%> (-2.48%) ⬇️
panel/io/callbacks.py 54.16% <0.00%> (-2.42%) ⬇️
panel/io/state.py 58.42% <0.00%> (-2.28%) ⬇️
panel/pane/plot.py 55.61% <0.00%> (-2.14%) ⬇️
panel/pane/streamz.py 65.71% <0.00%> (-1.86%) ⬇️
panel/models/echarts.py 85.71% <0.00%> (-1.79%) ⬇️
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5604328...0425430. Read the comment docs.

@philippjfr philippjfr merged commit a6dbf03 into master May 18, 2021
@philippjfr philippjfr deleted the actions_badge_fix branch May 18, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants