Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jslinking Parameterized class #2441

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Support jslinking Parameterized class #2441

merged 2 commits into from
Jun 29, 2021

Conversation

philippjfr
Copy link
Member

The ReactiveHTML implementation also included the ability to generate a DataModel for a Parameterized object. Since we already implemented this, we should also provide for the ability to set up bi-directional linking between Parameterized objects and other components. By adding a helper function called create_linked_datamodel which creates a Bokeh DataModel and links it to the provided Parameterized object we can easily support this usecase.

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #2441 (5f4a16f) into master (abc56e7) will decrease coverage by 0.07%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2441      +/-   ##
==========================================
- Coverage   83.47%   83.40%   -0.08%     
==========================================
  Files         182      182              
  Lines       22668    22707      +39     
==========================================
+ Hits        18923    18939      +16     
- Misses       3745     3768      +23     
Impacted Files Coverage Δ
panel/links.py 80.15% <55.88%> (-4.39%) ⬇️
panel/models/reactive_html.py 79.20% <100.00%> (-1.20%) ⬇️
panel/reactive.py 75.46% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc56e7...5f4a16f. Read the comment docs.

@philippjfr philippjfr merged commit 0548872 into master Jun 29, 2021
@philippjfr philippjfr deleted the link_parameterized branch June 29, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant