Change binder link from master to binder branch for robustness #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2703 +/- ##
==========================================
- Coverage 81.81% 81.81% -0.01%
==========================================
Files 187 187
Lines 23905 23905
==========================================
- Hits 19558 19557 -1
- Misses 4347 4348 +1
Continue to review full report at Codecov.
|
|
Shouldn't we point it to the last release instead? |
philippjfr
reviewed
Sep 2, 2021
| @@ -11,7 +11,7 @@ | |||
| | Latest dev release | [](https://github.com/holoviz/panel/tags) [](https://pyviz-dev.github.io/panel/) | | |||
| | Latest release | [](https://github.com/holoviz/panel/releases) [](https://pypi.python.org/pypi/panel) [](https://anaconda.org/pyviz/panel) [](https://anaconda.org/conda-forge/panel) [](https://anaconda.org/anaconda/panel) | | |||
| | Docs | [](https://github.com/holoviz/panel/tree/gh-pages) [](https://panel.holoviz.org) | | |||
| | Binder | [](https://mybinder.org/v2/gh/holoviz/panel/master?urlpath=lab/tree/examples) | | |||
| | Binder | [](https://mybinder.org/v2/gh/holoviz/panel/binder?urlpath=lab/tree/examples) | | |||
There was a problem hiding this comment.
Suggested change
| | Binder | [](https://mybinder.org/v2/gh/holoviz/panel/binder?urlpath=lab/tree/examples) | | |
| | Binder | [](https://mybinder.org/v2/gh/holoviz/panel/v0.12.1?urlpath=lab/tree/examples) | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses suggestion 2 of #2702
The master branch is always changing which means
I suggest changing to a branch called
binder.I've already created the
binderbranch from thev0.12.1(git checkout tags/v0.12.1) and tested that it works.You can test binder via https://mybinder.org/v2/gh/holoviz/panel/binder?urlpath=lab/tree/examples
Release Procedure
Please note that when ever a new version of Panel is released a step in that process is to merge the release into the
binderbranch and manually test that binder can build the image and that things works. But it would be a good test anyways that Panel indeed works in a fresh environment and that all the gallery apps works etc.Improvements to binder branch
Any improvements to the binder branch during releases should start from the binder branch and not from master.