Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jupyter server root_dir with lab extension #3172

Merged

Conversation

govinda18
Copy link
Contributor

Jupyter sends path relative to the root_dir which can be different from the cwd. This commit fixes the lab extension for panel preview to account for root_dir.

Reference: #3170

Jupyter sends path relative to the root_dir which can be different from the cwd. This commit fixes the lab extension for panel preview to account for root_dir.

Reference: holoviz#3170
@philippjfr
Copy link
Member

Amazing, thanks for contributing! Will merge when tests pass.

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #3172 (65dc5fa) into master (5df060d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3172      +/-   ##
==========================================
- Coverage   82.98%   82.95%   -0.03%     
==========================================
  Files         192      192              
  Lines       25502    25508       +6     
==========================================
- Hits        21163    21161       -2     
- Misses       4339     4347       +8     
Impacted Files Coverage Δ
panel/io/jupyter_server_extension.py 0.00% <0.00%> (ø)
panel/io/reload.py 69.23% <0.00%> (-2.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df060d...65dc5fa. Read the comment docs.

@philippjfr philippjfr merged commit 6a305ff into holoviz:master Feb 3, 2022
philippjfr pushed a commit that referenced this pull request Mar 26, 2022
Jupyter sends path relative to the root_dir which can be different from the cwd. This commit fixes the lab extension for panel preview to account for root_dir.

Reference: #3170
philippjfr added a commit that referenced this pull request Mar 27, 2022
* Fix jinja2 imports (#3258)

* fix: wrong offset when memoryview format is non-byte (#3206)

the offset should be in bytes, not elements. See also bokeh/ipywidgets_bokeh#46 (comment)

* Support jupyter server root_dir with lab extension (#3172)

Jupyter sends path relative to the root_dir which can be different from the cwd. This commit fixes the lab extension for panel preview to account for root_dir.

Reference: #3170

* DOC: add note on enabling panel widget on Jupyter Lab (#3029)

* Remove redundant and confusing JupyterLab install instructions (#3037)

* Remove reference to Python 2 and link to Travis

* Remove redondant install instructions to work with Jupyter

* Update CHANGELOG

* Add setuptools to build requirements

* use https instead of the git:// protocol in GHA (#3092)

* Try to switch to setuptools (#3138)

* Try to switch to setuptools

* Continue on error

* CI: fix Macos tests workflow (#3160)

* attempt to fix CI on macos

* forgot bokeh channel

* remove strict setting

* reset strict and add pyctdev channel

* remove continue_on_error and test py310

* clean up test workflow

* add comment about PYCTDEV_SELF_CHANNEL

* remove py310

* Revert change to build backend

* Update setuptools pin

* Pin setuptools

* Further pin updates

* Pin setuptools (#3265)

* Fix image_url test

* Pin pyvista

* Bump panel.js version

* Fix GH workflows

* Bump panel.js version

Co-authored-by: Maarten Breddels <maartenbreddels@gmail.com>
Co-authored-by: Govinda Totla <govinda.totla.cse16@itbhu.ac.in>
Co-authored-by: Ray Bell <rayjohnbell0@gmail.com>
Co-authored-by: Maxime Liquet <35924738+maximlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants