Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that once instantiated loading_indicator is disconnected from default #6343

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

philippjfr
Copy link
Member

Fixes #6306

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d35ad7a) 82.65% compared to head (c89ea50) 82.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6343      +/-   ##
==========================================
- Coverage   82.65%   82.64%   -0.01%     
==========================================
  Files         305      305              
  Lines       45484    45486       +2     
==========================================
  Hits        37594    37594              
- Misses       7890     7892       +2     
Flag Coverage Δ
ui-tests 38.56% <100.00%> (-0.02%) ⬇️
unitexamples-tests 71.64% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 0b18620 into main Feb 14, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the loading_indicator_default branch February 14, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading Indicator never removed when set via pn.config.set context manager
1 participant