Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "gap" property to FlexBox #6354

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Add "gap" property to FlexBox #6354

merged 3 commits into from
Feb 18, 2024

Conversation

OSuwaidi
Copy link
Contributor

@OSuwaidi OSuwaidi commented Feb 16, 2024

This PR addresses issue #6350.

@OSuwaidi OSuwaidi changed the title added "gap" property to FlexBox Add "gap" property to FlexBox Feb 16, 2024
@hoxbro hoxbro linked an issue Feb 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47e7bfa) 84.11% compared to head (e87010d) 83.58%.
Report is 4 commits behind head on main.

❗ Current head e87010d differs from pull request most recent head aa49e6e. Consider uploading reports for the commit aa49e6e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6354      +/-   ##
==========================================
- Coverage   84.11%   83.58%   -0.53%     
==========================================
  Files         305      305              
  Lines       45499    45500       +1     
==========================================
- Hits        38271    38032     -239     
- Misses       7228     7468     +240     
Flag Coverage Δ
ui-tests 40.25% <100.00%> (-0.53%) ⬇️
unitexamples-tests 71.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panel/layout/flex.py Outdated Show resolved Hide resolved
@philippjfr
Copy link
Member

Really appreciate it @OSuwaidi!

@philippjfr philippjfr merged commit 0980fa4 into holoviz:main Feb 18, 2024
3 checks passed
@OSuwaidi OSuwaidi deleted the test_b branch February 18, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add gap property to pn.FlexBox()
2 participants