Fix reactive html issues #6358
Merged
Fix reactive html issues #6358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
approved these changes
Feb 18, 2024
philippjfr
reviewed
Feb 18, 2024
| object = param.Parameter() | ||
|
|
||
| _ignored_refs = ("object",) | ||
| object = param.Parameter(allow_refs=False) |
There was a problem hiding this comment.
Wonder if we should set it to False by default for custom components.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6358 +/- ##
===========================================
- Coverage 83.64% 39.67% -43.98%
===========================================
Files 305 305
Lines 45547 45533 -14
===========================================
- Hits 38099 18063 -20036
- Misses 7448 27470 +20022
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
philippjfr
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things in Panel has changed since I contributed the ReactiveHTML guides. This PR handles the changes.
Example issue