Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure markdown parsing does not choke on partial links #6535

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

philippjfr
Copy link
Member

Fixes #6520

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 82.87%. Comparing base (9641c9b) to head (e202069).
Report is 1 commits behind head on main.

Files Patch % Lines
panel/pane/markup.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6535      +/-   ##
==========================================
+ Coverage   81.86%   82.87%   +1.01%     
==========================================
  Files         313      313              
  Lines       45931    45945      +14     
==========================================
+ Hits        37600    38077     +477     
+ Misses       8331     7868     -463     
Flag Coverage Δ
ui-tests 40.09% <26.66%> (+3.04%) ⬆️
unitexamples-tests 71.07% <73.33%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 1333333 into main Mar 20, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the md_link_parser_fix branch March 20, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError occurs when markdown chat message that gets streamed out has incomplete markdown URLs.
1 participant