-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSS on mouse interaction with card #6636
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6636 +/- ##
===========================================
+ Coverage 39.99% 82.89% +42.89%
===========================================
Files 313 313
Lines 46103 46119 +16
===========================================
+ Hits 18438 38229 +19791
+ Misses 27665 7890 -19775
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can't this be done with CSS? |
Yeah, this should definitely be done with CSS. |
* Update gallery endpoint * Add Panel chat examples
Reducing contrast on hover seems a little counter-intuitive, I'll try to come up with a different visual change but am open to your suggestions. |
Brightness didn't seem to work for me. Opacity is worse than contrast. Transform is a little strange so I stuck with contrast. Color maybe could change to theme accent
|
I'd be okay with a box-shadow of some sort. |
Here's box shadow. Screen.Recording.2024-04-17.at.11.17.31.AM.mov |
Better notify the user that it's clickable and makes it feel nicer.
Screen.Recording.2024-04-01.at.2.24.50.PM.mov