Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure binary buffers are correctly extracted in CommManager #6818

Merged
merged 5 commits into from
May 9, 2024
Merged

Ensure binary buffers are correctly extracted in CommManager #6818

merged 5 commits into from
May 9, 2024

Conversation

philippjfr
Copy link
Member

Binary buffers in Bokeh are now held in a Buffer object which means our old check for isPlainObject no longer works and we have to explicitly check for it.

  • Add test

@philippjfr
Copy link
Member Author

Fixes holoviz/holoviews#6225

@philippjfr philippjfr changed the title Ensure binary buffers are correctly extract in CommManager Ensure binary buffers are correctly extracted in CommManager May 9, 2024
@philippjfr philippjfr merged commit 5980533 into main May 9, 2024
9 of 14 checks passed
@philippjfr philippjfr deleted the comm_manager_fix_buffer_detect branch May 9, 2024 16:39
philippjfr added a commit that referenced this pull request May 9, 2024
@philippjfr
Ensure binary buffers are correctly extracted in CommManager (#6818)
2850bc7
@philippjfr philippjfr mentioned this pull request May 21, 2024
Merged
@ahuang11 ahuang11 mentioned this pull request May 28, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@philippjfr